CS_learn/tech-interview-handbook
1
0
Fork 0
mirror of https://github.com/yangshun/tech-interview-handbook.git synced 2026-02-12 15:16:23 +08:00
Code Issues Packages Projects Releases Wiki Activity

[offers][fix] Fix user's offers appearing in own top relevant offers during analysis

Browse Source
This commit is contained in:
Bryann Yeap Kok Keong
2022-11-05 08:10:15 +08:00
parent fec915cffa
commit cd4ed504df
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
apps/portal/src/utils/offers/analysis/analysisGeneration.ts
View File

@@ -251,6 +251,8 @@ export const generateAnalysis = async (params: {
},
});
const offerIds = offers.map((offer) => offer.id);
// COMPANY ANALYSIS
const companyMap = new Map<string, Offer>();
offers.forEach((offer) => {
@@ -275,9 +277,9 @@ export const generateAnalysis = async (params: {
? 100
: 100 - (100 * companyIndex) / (similarCompanyOffers.length - 1);
// Get top offers (excluding user's offer)
// Get top offers (excluding user's offers)
similarCompanyOffers = similarCompanyOffers.filter(
(offer) => offer.id !== companyOffer.id,
(offer) => !offerIds.includes(offer.id),
);
const noOfSimilarCompanyOffers = similarCompanyOffers.length;
@@ -311,9 +313,7 @@ export const generateAnalysis = async (params: {
? 100
: 100 - (100 * overallIndex) / (similarOffers.length - 1);
similarOffers = similarOffers.filter(
(offer) => offer.id !== overallHighestOffer.id,
);
similarOffers = similarOffers.filter((offer) => !offerIds.includes(offer.id));
const noOfSimilarOffers = similarOffers.length;
const similarOffers90PercentileIndex = Math.ceil(noOfSimilarOffers * 0.1);