clean up some only_if's to make them 'when's and easier to read

playbooks/host_reboot.yml

@@ -13,20 +13,20 @@
   - name: tell nagios to shush
     action: nagios action=silence host=${inventory_hostname_short}
     delegate_to: noc01.phx2.fedoraproject.org
-    only_if: "'${needsreboot.stdout}'.find('yes') != -1"
+    when:"'yes' in needsreboot.stdout"
 
   - name: reboot the host
     action: command /sbin/reboot
-    only_if: "'${needsreboot.stdout}'.find('yes') != -1"
+    when:"'yes' in needsreboot.stdout"
 
   - name: wait for host to come back - up to 6 minutes
     local_action: wait_for host=${inventory_hostname} port=22 delay=30 timeout=420
-    only_if: "'${needsreboot.stdout}'.find('yes') != -1"
+    when:"'yes' in needsreboot.stdout"
 
   - name: tell nagios to unshush
     action: nagios action=unsilence host=${inventory_hostname_short}
     delegate_to: noc01.phx2.fedoraproject.org
-    only_if: "'${needsreboot.stdout}'.find('yes') != -1"
+    when:"'yes' in needsreboot.stdout"
 
 
 

playbooks/package_update.yml

@@ -20,7 +20,7 @@
   
   - name: run rkhunter --propupd
     action: command /usr/bin/rkhunter --propupd
-    only_if: "'${rkhunter.rc}' == '0'"
+    when: rkhunter|success
 
 
 

playbooks/vhost_update.yml

@@ -33,7 +33,7 @@
   
   - name: run rkhunter --propupd
     action: command /usr/bin/rkhunter --propupd
-    only_if: "'${rkhunter.rc}' == '0'"
+    when: rkhunter|success