Revert "greenwave: set up secret volumes in the developmentconfig instead of the playbook"

This reverts commit bc6ebfb8a1.

This is because OpenShift doesn't suppport for using absolute path for secret volums.

playbooks/openshift-apps/greenwave.yml

@@ -17,6 +17,19 @@
     appowners:
     - mjia
     - dcallagh
+  # These secret roles also break if the secret already exists.  Can only be run once.
+  #- role: openshift/secret-file
+  #  app: greenwave
+  #  secret_name: greenwave-fedmsg-key
+  #  key: fedmsg-greenwave.key
+  #  privatefile: fedmsg-certs/keys/greenwave-greenwave-web-greenwave.app.os.stg.fedoraproject.org.key
+  #  when: env == "staging"
+  #- role: openshift/secret-file
+  #  app: greenwave
+  #  secret_name: greenwave-fedmsg-crt
+  #  key: fedmsg-greenwave.crt
+  #  privatefile: fedmsg-certs/keys/greenwave-greenwave-web-greenwave.app.os.stg.fedoraproject.org.crt
+  #  when: env == "staging"
   - { role: openshift/object, app: greenwave, file: imagestream.yml }
   - { role: openshift/object, app: greenwave, template: buildconfig.yml }
   - { role: openshift/start-build, app: greenwave, name: greenwave-docker-build }

roles/openshift-apps/greenwave/files/deploymentconfig.yml

@@ -98,26 +98,13 @@ spec:
       - name: fedmsg-config-volume
         configMap:
           name: greenwave-fedmsg-configmap
+      # This secret volume gets set up in the playbook
       - name: fedmsg-key-volume
         secret:
           secretName: greenwave-fedmsg-key
-          items:
-          - key: fedmsg-greenwave.key
-{% if env == 'staging' %}
-            path: {{private}}/files/fedmsg-certs/keys/greenwave-greenwave-web-greenwave.app.os.stg.fedoraproject.org.key
-{% else %}
-            path: {{private}}/files/fedmsg-certs/keys/greenwave-greenwave-web-greenwave.app.os.fedoraproject.org.key
-{% endif %}
       - name: fedmsg-crt-volume
         secret:
           secretName: greenwave-fedmsg-crt
-          items:
-          - key: fedmsg-greenwave.crt
-{% if env == 'staging' %}
-            path: {{private}}/files/fedmsg-certs/keys/greenwave-greenwave-web-greenwave.app.os.stg.fedoraproject.org.crt
-{% else %}
-            path: {{private}}/files/fedmsg-certs/keys/greenwave-greenwave-web-greenwave.app.os.fedoraproject.org.crt
-{% endif %}
   triggers:
   - type: ImageChange
     imageChangeParams: