Fix hostname calls to use hostname module instead of shell

playbooks/groups/copr-backend.yml

@@ -32,7 +32,7 @@
   - include: "{{ tasks }}/cloud_setup_basic.yml"
 
   - name: set hostname (required by some services, at least postfix need it)
-    shell: "hostname {{copr_hostbase}}.cloud.fedoraproject.org"
+    hostname: "{{copr_hostbase}}.cloud.fedoraproject.org"
 
 - name: provision instance
   hosts: copr-back:copr-back-stg

playbooks/groups/copr-dist-git.yml

@@ -23,7 +23,7 @@
   tasks:
   - include: "{{ tasks }}/cloud_setup_basic.yml"
   - name: set hostname (required by some services, at least postfix need it)
-    shell: "hostname {{copr_hostbase}}.cloud.fedoraproject.org"
+    hostname: "{{copr_hostbase}}.cloud.fedoraproject.org"
   - name: install dnf
     yum: state=present name=dnf
 

playbooks/groups/copr-frontend.yml

@@ -23,7 +23,7 @@
   tasks:
   - include: "{{ tasks }}/cloud_setup_basic.yml"
   - name: set hostname (required by some services, at least postfix need it)
-    shell: "hostname {{copr_hostbase}}.cloud.fedoraproject.org"
+    hostname: "{{copr_hostbase}}.cloud.fedoraproject.org"
 
 - name: provision instance
   hosts: copr-front:copr-front-stg

playbooks/groups/copr-keygen.yml

@@ -31,7 +31,7 @@
   tasks:
   - include: "{{ tasks }}/cloud_setup_basic.yml"
   - name: set hostname (required by some services, at least postfix need it)
-    shell: "hostname {{copr_hostbase}}.cloud.fedoraproject.org"
+    hostname: "{{copr_hostbase}}.cloud.fedoraproject.org"
 
 - name: provision instance
   hosts: copr-keygen:copr-keygen-stg

playbooks/groups/docs-dev.yml

@@ -23,4 +23,4 @@
   pre_tasks:
   - include: "{{ tasks }}/cloud_setup_basic.yml"
   - name: set hostname (required by some services, at least postfix need it)
-    shell: "hostname {{inventory_hostname}}"
+    hostname: name="{{inventory_hostname}}"

playbooks/groups/jenkins-master.yml

@@ -23,7 +23,7 @@
   pre_tasks:
   - include: "{{ tasks }}/cloud_setup_basic.yml"
   - name: set hostname (required by some services, at least postfix need it)
-    shell: "hostname {{inventory_hostname}}"
+    hostname: name="{{inventory_hostname}}"
   - include: "{{ tasks }}/yumrepos.yml"
 
 - name: provision instance

playbooks/groups/jenkins-slave.yml

@@ -23,7 +23,7 @@
   pre_tasks:
   - include: "{{ tasks }}/cloud_setup_basic.yml"
   - name: set hostname (required by some services, at least postfix need it)
-    shell: "hostname {{inventory_hostname}}"
+    hostname: name="{{inventory_hostname}}"
   - include: "{{ tasks }}/yumrepos.yml"
 
 - name: provision instance

playbooks/groups/twisted-buildbots.yml

@@ -23,7 +23,7 @@
   pre_tasks:
   - include: "{{ tasks }}/cloud_setup_basic.yml"
   - name: set hostname (required by some services, at least postfix need it)
-    shell: "hostname {{inventory_hostname}}"
+    hostname: name="{{inventory_hostname}}"
  
   tasks:
 

playbooks/hosts/communityblog.fedorainfracloud.org.yml

@@ -23,7 +23,7 @@
   pre_tasks:
   - include: "{{ tasks }}/cloud_setup_basic.yml"
   - name: set hostname (required by some services, at least postfix need it)
-    shell: "hostname {{inventory_hostname}}"
+    hostname: name="{{inventory_hostname}}"
 
   tasks:
   - name: add packages

playbooks/hosts/darkserver-dev.fedorainfracloud.org.yml

@@ -24,4 +24,4 @@
   pre_tasks:
   - include: "{{ tasks }}/cloud_setup_basic.yml"
   - name: set hostname (required by some services, at least postfix need it)
-    shell: "hostname {{inventory_hostname}}"
+    hostname: name="{{inventory_hostname}}"

playbooks/hosts/developer.fedorainfracloud.org.yml

@@ -23,4 +23,4 @@
   tasks:
   - include: "{{ tasks }}/cloud_setup_basic.yml"
   - name: set hostname (required by some services, at least postfix need it)
-    shell: "hostname {{inventory_hostname}}"
+    hostname: name="{{inventory_hostname}}"

playbooks/hosts/eclipse.fedorainfracloud.org.yml

@@ -26,4 +26,4 @@
   tasks:
   - include: "{{ tasks }}/cloud_setup_basic.yml"
   - name: set hostname (required by some services, at least postfix need it)
-    shell: "hostname {{inventory_hostname}}"
+    hostname: name="{{inventory_hostname}}"

playbooks/hosts/faitout.fedorainfracloud.org.yml

@@ -23,4 +23,4 @@
   pre_tasks:
   - include: "{{ tasks }}/cloud_setup_basic.yml"
   - name: set hostname (required by some services, at least postfix need it)
-    shell: "hostname {{inventory_hostname}}"
+    hostname: name="{{inventory_hostname}}"

playbooks/hosts/fas2-dev.fedorainfracloud.org.yml

@@ -23,4 +23,4 @@
   pre_tasks:
   - include: "{{ tasks }}/cloud_setup_basic.yml"
   - name: set hostname (required by some services, at least postfix need it)
-    shell: "hostname {{inventory_hostname}}"
+    hostname: name="{{inventory_hostname}}"

playbooks/hosts/fas3-dev.fedorainfracloud.org.yml

@@ -23,4 +23,4 @@
   pre_tasks:
   - include: "{{ tasks }}/cloud_setup_basic.yml"
   - name: set hostname (required by some services, at least postfix need it)
-    shell: "hostname {{inventory_hostname}}"
+    hostname: name="{{inventory_hostname}}"

playbooks/hosts/fedimg-dev.fedorainfracloud.org.yml

@@ -30,4 +30,4 @@
   pre_tasks:
   - include: "{{ tasks }}/cloud_setup_basic.yml"
   - name: set hostname (required by some services, at least postfix need it)
-    shell: "hostname {{inventory_hostname}}"
+    hostname: name="{{inventory_hostname}}"

playbooks/hosts/fedora-bootstrap.fedorainfracloud.org.yml

@@ -23,7 +23,7 @@
   pre_tasks:
   - include: "{{ tasks }}/cloud_setup_basic.yml"
   - name: set hostname (required by some services, at least postfix need it)
-    shell: "hostname {{inventory_hostname}}"
+    hostname: name="{{inventory_hostname}}"
 
   tasks:
   - name: add packages

playbooks/hosts/glittergallery-dev.fedorainfracloud.org.yml

@@ -23,4 +23,4 @@
   pre_tasks:
   - include: "{{ tasks }}/cloud_setup_basic.yml"
   - name: set hostname (required by some services, at least postfix need it)
-    shell: "hostname {{inventory_hostname}}"
+    hostname: name="{{inventory_hostname}}"

playbooks/hosts/grafana.cloud.fedoraproject.org.yml

@@ -41,4 +41,4 @@
   pre_tasks:
   - include: "{{ tasks }}/cloud_setup_basic.yml"
   - name: set hostname (required by some services, at least postfix need it)
-    shell: "hostname {{inventory_hostname}}"
+    hostname: name="{{inventory_hostname}}"

playbooks/hosts/iddev.fedorainfracloud.org.yml

@@ -32,7 +32,7 @@
   tasks:
   - include: "{{ tasks }}/cloud_setup_basic.yml"
   - name: set hostname (required by some services, at least postfix need it)
-    shell: "hostname {{inventory_hostname}}"
+    hostname: name="{{inventory_hostname}}"
   - include: "{{ tasks }}/mod_wsgi.yml"
 
   handlers:

playbooks/hosts/insim.fedorainfracloud.org.yml

@@ -24,7 +24,7 @@
   pre_tasks:
   - include: "{{ tasks }}/cloud_setup_basic.yml"
   - name: set hostname (required by some services, at least postfix need it)
-    shell: "hostname {{inventory_hostname}}"
+    hostname: name="{{inventory_hostname}}"
 
   tasks:
   - name: install basic packages

playbooks/hosts/lists-dev.fedorainfracloud.org.yml

@@ -27,7 +27,7 @@
   pre_tasks:
   - include: "{{ tasks }}/cloud_setup_basic.yml"
   - name: set hostname (required by some services, at least postfix need it)
-    shell: "hostname {{inventory_hostname}}"
+    hostname: name="{{inventory_hostname}}"
 
   roles:
   - sudo

playbooks/hosts/magazine.fedorainfracloud.org.yml

@@ -23,7 +23,7 @@
   pre_tasks:
   - include: "{{ tasks }}/cloud_setup_basic.yml"
   - name: set hostname (required by some services, at least postfix need it)
-    shell: "hostname {{inventory_hostname}}"
+    hostname: name="{{inventory_hostname}}"
 
   tasks:
   - name: add packages

playbooks/hosts/modernpaste.fedorainfracloud.org.yml

@@ -32,5 +32,5 @@
   tasks:
   - include: "{{ tasks }}/cloud_setup_basic.yml"
   - name: set hostname (required by some services, at least postfix need it)
-    shell: "hostname {{inventory_hostname}}"
+    hostname: name="{{inventory_hostname}}"
   - include: "{{ tasks }}/mod_wsgi.yml"

playbooks/hosts/osbs-dev.fedorainfracloud.org.yml

@@ -22,7 +22,7 @@
   pre_tasks:
     - include: "{{ tasks }}/cloud_setup_basic.yml"
     - name: set hostname (required by some services, at least postfix need it)
-      shell: "hostname {{inventory_hostname}}"
+      hostname: name="{{inventory_hostname}}"
 
 - name: bootstrap ansible py2
   hosts: osbs-dev.fedorainfracloud.org

playbooks/hosts/piwik.fedorainfracloud.org.yml

@@ -37,4 +37,4 @@
   tasks:
   - include: "{{ tasks }}/cloud_setup_basic.yml"
   - name: set hostname (required by some services, at least postfix need it)
-    shell: "hostname {{inventory_hostname}}"
+    hostname: name="{{inventory_hostname}}"

playbooks/hosts/regcfp.fedorainfracloud.org.yml

@@ -23,7 +23,7 @@
   pre_tasks:
   - include: "{{ tasks }}/cloud_setup_basic.yml"
   - name: set hostname (required by some services, at least postfix need it)
-    shell: "hostname {{inventory_hostname}}"
+    hostname: name="{{inventory_hostname}}"
 
   roles:
   - postgresql_server

playbooks/hosts/shumgrepper-dev.fedorainfracloud.org.yml

@@ -23,4 +23,4 @@
   pre_tasks:
   - include: "{{ tasks }}/cloud_setup_basic.yml"
   - name: set hostname (required by some services, at least postfix need it)
-    shell: "hostname {{inventory_hostname}}"
+    hostname: name="{{inventory_hostname}}"

playbooks/hosts/taiga.fedorainfracloud.org.yml

@@ -22,7 +22,7 @@
   pre_tasks:
   - include: "{{ tasks }}/cloud_setup_basic.yml"
   - name: set hostname (required by some services, at least postfix need it)
-    shell: "hostname {{inventory_hostname}}"
+    hostname: name="{{inventory_hostname}}"
 
   roles:
   - role: taiga

playbooks/hosts/taigastg.fedorainfracloud.org.yml

@@ -23,7 +23,7 @@
   pre_tasks:
   - include: "{{ tasks }}/cloud_setup_basic.yml"
   - name: set hostname (required by some services, at least postfix need it)
-    shell: "hostname {{inventory_hostname}}"
+    hostname: name="{{inventory_hostname}}"
 
   roles:
   - role: taiga

playbooks/hosts/testdays.fedorainfracloud.org.yml

@@ -24,7 +24,7 @@
   pre_tasks:
   - include: "{{ tasks }}/cloud_setup_basic.yml"
   - name: set hostname (required by some services, at least postfix need it)
-    shell: "hostname {{inventory_hostname}}"
+    hostname: name="{{inventory_hostname}}"
 
   tasks:
   - name: add infrastructure repo