chore: use annotations instead of in house linter (#2905)

* ci: make compile add warnings to file

* chore: use cpp-linter instead of inhouse linter

* chore: use abinoda instead of pullreminders for label-when-approved
This commit is contained in:
realstealthninja
2024-11-24 13:14:42 +05:30
committed by GitHub
parent 94202ec13f
commit 41653de718
2 changed files with 16 additions and 42 deletions

View File

@@ -5,10 +5,10 @@ jobs:
name: Add "approved" label when approved
runs-on: ubuntu-latest
steps:
- name: Add "approved" label when approved
uses: pullreminders/label-when-approved-action@master
env:
APPROVALS: "1"
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
ADD_LABEL: "approved"
REMOVE_LABEL: ""
- name: Add "approved" label when approved
uses: abinoda/label-when-approved-action@v1.0.7
env:
APPROVALS: "1"
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
ADD_LABEL: "approved"
REMOVE_LABEL: ""

View File

@@ -9,42 +9,14 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: cpp-linter/cpp-linter-action@v2
id: linter
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
fetch-depth: 0
- uses: actions/setup-python@v4
- name: requirements
run: |
sudo apt-get -qq update
sudo apt-get -qq install clang-tidy clang-format
# checks are passing with less errors when used with this version.
# The default installs v6.0 which did not work out well in my tests
- name: Setup Git Specs
run: |
git config --global user.name github-actions[bot]
git config --global user.email 'github-actions[bot]@users.noreply.github.com'
- name: Filename Formatter
run: |
wget https://raw.githubusercontent.com/TheAlgorithms/scripts/main/filename_formatter.sh
chmod +x filename_formatter.sh
./filename_formatter.sh . .cpp,.hpp
- name: Get file changes
run: |
git branch
git diff --diff-filter=dr --name-only origin/master > git_diff.txt
echo "Files changed-- `cat git_diff.txt`"
- name: Configure for static lint checks
# compiling first gives clang-tidy access to all the header files and settings used to compile the programs.
# This will check for macros, if any, on linux and not for Windows. But the use of portability checks should
# be able to catch any errors for other platforms.
run: cmake -B build -S . -DCMAKE_EXPORT_COMPILE_COMMANDS=ON
- name: Lint modified files
shell: bash
run: python3 scripts/file_linter.py
- name: Commit and push changes
run: |
git diff DIRECTORY.md
git commit -am "clang-format and clang-tidy fixes for ${GITHUB_SHA::8}" || true
git push origin HEAD:$GITHUB_REF || true
style: "file"
tidy-checks: ".clang-tidy"
thread-comments: ${{ github.event_name == 'pull_request' && 'update' }}
build:
name: Compile checks
@@ -59,6 +31,8 @@ jobs:
- uses: actions/checkout@v4
with:
submodules: true
- name: GCC problem matcher
uses: ammaraskar/gcc-problem-matcher@0.3.0
- run: |
cmake -B ./build -S .
cmake --build build --parallel 4