backup/C-Plus-Plus
1
0
Fork 0
mirror of https://github.com/TheAlgorithms/C-Plus-Plus.git synced 2026-02-13 15:37:06 +08:00
Code Issues Projects Releases Wiki Activity

fix: remove memory leak iterative_factorial.cpp (#2535)

Browse Source 
* fix: remove memory leak

* tests: check properly if `math::iterativeFactorial` throws
This commit is contained in:
Piotr Idzik
2024-08-30 19:20:08 +02:00
committed by GitHub
parent 2dadbf73f4
commit 8a368240e2
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
math/iterative_factorial.cpp
View File

@@ -46,7 +46,7 @@ namespace math {
*/
uint64_t iterativeFactorial(uint8_t n) {
if (n > 20) {
throw new std::invalid_argument("Maximum n value is 20");
throw std::invalid_argument("Maximum n value is 20");
}
// 1 because it is the identity number of multiplication.
@@ -101,12 +101,14 @@ static void test() {
std::cout << "Exception test \n"
"Input: 21 \n"
"Expected output: Exception thrown \n";
bool wasExceptionThrown = false;
try {
math::iterativeFactorial(21);
} catch (std::invalid_argument* e) {
std::cout << "Exception thrown successfully \nContent: " << e->what()
<< "\n";
} catch (const std::invalid_argument&) {
wasExceptionThrown = true;
}
assert(wasExceptionThrown);
std::cout << "All tests have passed successfully.\n";
}