backup/C-Plus-Plus
1
0
Fork 0
mirror of https://github.com/TheAlgorithms/C-Plus-Plus.git synced 2026-02-11 06:26:05 +08:00
Code Issues Projects Releases Wiki Activity

fix: remove memory leak in stack

Browse Source
This commit is contained in:
piotr.idzik
2022-10-12 19:23:35 +02:00
committed by Piotr Idzik
parent 59a0d3a069
commit b4bc3b01fd
1 changed files with 18 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
data_structures/stack.h
View File

@@ -47,10 +47,6 @@ class stack {
explicit stack(const stack<Type> &otherStack) {
node<Type> *newNode, *current, *last;
/* If stack is no empty, make it empty */
if (stackTop != nullptr) {
stackTop = nullptr;
}
if (otherStack.stackTop == nullptr) {
stackTop = nullptr;
} else {
@@ -73,8 +69,20 @@ class stack {
size = otherStack.size;
}
private:
void delete_all_nodes() {
node<Type> *curNode = stackTop;
while (curNode != nullptr) {
const auto tmpNode = curNode->next;
delete curNode;
curNode = tmpNode;
}
stackTop = nullptr;
}
public:
/** Destructor */
~stack() {}
~stack() { delete_all_nodes(); }
/** Determine whether the stack is empty */
bool isEmptyStack() { return (stackTop == nullptr); }
@@ -109,16 +117,16 @@ class stack {
}
/** Clear stack */
void clear() { stackTop = nullptr; }
void clear() {
delete_all_nodes();
size = 0;
}
/** Overload "=" the assignment operator */
stack<Type> &operator=(const stack<Type> &otherStack) {
node<Type> *newNode, *current, *last;
/* If stack is no empty, make it empty */
if (stackTop != nullptr) {
stackTop = nullptr;
}
delete_all_nodes();
if (otherStack.stackTop == nullptr) {
stackTop = nullptr;
} else {