mirror of
https://gitea.com/gitea/act_runner.git
synced 2026-05-01 08:20:33 +08:00
2516573592
Removes 88 `nolint` directives (386 → 298) via mechanical, zero-regression cleanups: - **38 `bodyclose`** in `act/artifactcache/handler_test.go`: replaced by `defer resp.Body.Close()` after each HTTP call. - **21 dead directives** (`gocyclo`, `dogsled`, `contextcheck`): none of these linters are enabled in `.golangci.yml`, so the directives were doing nothing. - **29 `testifylint`** directives whose underlying issues were addressed by mechanical rewrites: - `assert.Nil(t, err)` → `assert.NoError(t, err)` - `assert.NotNil(t, err)` → `assert.Error(t, err)` - `assert.Equal(t, true/false, x)` → `assert.True/False(t, x)` - `assert.Equal(t, 0, len(x))` → `assert.Empty(t, x)` - `assert.Equal(t, N, len(x))` → `assert.Len(t, x, N)` - `assert.Len(t, x, 0)` → `assert.Empty(t, x)` Many `testifylint` directives still apply because they flag `require-error` (i.e. testifylint wants `require.NoError` instead of `assert.NoError` for early bail-out). That's a behavior change (fail-fast vs continue) and out of scope for this purely mechanical cleanup — those can be addressed in a follow-up. Same for `expected-actual`, `equal-values`, `error-is-as`, and the remaining `nilnil` / `unparam` / `forbidigo` / `staticcheck` / `goheader` / `dupl` directives. `golangci-lint run` is clean. Tests pass for all touched packages. --- This PR was written with the help of Claude Opus 4.7 Reviewed-on: https://gitea.com/gitea/act_runner/pulls/864 Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: silverwind <2021+silverwind@noreply.gitea.com> Co-committed-by: silverwind <2021+silverwind@noreply.gitea.com>
68 lines
1.5 KiB
Go
68 lines
1.5 KiB
Go
// Copyright 2026 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package runner
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"gitea.com/gitea/act_runner/act/model"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"go.yaml.in/yaml/v4"
|
|
)
|
|
|
|
func TestMaxParallelStrategy(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
maxParallelString string
|
|
expectedMaxParallel int
|
|
}{
|
|
{
|
|
name: "max-parallel-1",
|
|
maxParallelString: "1",
|
|
expectedMaxParallel: 1,
|
|
},
|
|
{
|
|
name: "max-parallel-2",
|
|
maxParallelString: "2",
|
|
expectedMaxParallel: 2,
|
|
},
|
|
{
|
|
name: "max-parallel-default",
|
|
maxParallelString: "",
|
|
expectedMaxParallel: 4,
|
|
},
|
|
{
|
|
name: "max-parallel-10",
|
|
maxParallelString: "10",
|
|
expectedMaxParallel: 10,
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
matrix := map[string][]any{
|
|
"version": {1, 2, 3, 4, 5},
|
|
}
|
|
|
|
var rawMatrix yaml.Node
|
|
err := rawMatrix.Encode(matrix)
|
|
assert.NoError(t, err) //nolint:testifylint // pre-existing issue from nektos/act
|
|
|
|
job := &model.Job{
|
|
Strategy: &model.Strategy{
|
|
MaxParallelString: tt.maxParallelString,
|
|
RawMatrix: rawMatrix,
|
|
},
|
|
}
|
|
|
|
matrixes, err := job.GetMatrixes()
|
|
assert.NoError(t, err) //nolint:testifylint // pre-existing issue from nektos/act
|
|
assert.NotNil(t, matrixes)
|
|
assert.Len(t, matrixes, 5)
|
|
assert.Equal(t, tt.expectedMaxParallel, job.Strategy.MaxParallel)
|
|
})
|
|
}
|
|
}
|