mirror of
https://gitea.com/gitea/act_runner.git
synced 2026-04-24 21:00:27 +08:00
f923badec7
Use `golangci-lint fmt` to format code, upgrading `.golangci.yml` to v2 and mirroring the linter configuration used by https://github.com/go-gitea/gitea. `gci` now handles import ordering into standard, project-local, blank, and default groups. Mirrors https://github.com/go-gitea/gitea/pull/37194. Changes: - Upgrade `.golangci.yml` to v2 format with the same linter set as gitea (minus `prealloc`, `unparam`, `testifylint`, `nilnil` which produced too many pre-existing issues) - Add path-based exclusions (`bodyclose`, `gosec` in tests; `gosec:G115`/`G117` globally) - Run lint via `make lint-go` in CI instead of `golangci/golangci-lint-action`, matching the pattern used by other Gitea repos - Apply safe auto-fixes (`modernize`, `perfsprint`, `usetesting`, etc.) - Add explanations to existing `//nolint` directives - Remove dead code (unused `newRemoteReusableWorkflow` and `networkName`), duplicate imports, and shadowed `max` builtins - Replace deprecated `docker/distribution/reference` with `distribution/reference` - Fix `Deprecated:` comment casing and simplify nil/len checks --- This PR was written with the help of Claude Opus 4.7 Reviewed-on: https://gitea.com/gitea/act/pulls/163 Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: silverwind <me@silverwind.io> Co-committed-by: silverwind <me@silverwind.io>
124 lines
2.6 KiB
Makefile
124 lines
2.6 KiB
Makefile
PREFIX ?= /usr/local
|
|
VERSION ?= $(shell git describe --tags --dirty --always | sed -e 's/^v//')
|
|
IS_SNAPSHOT = $(if $(findstring -, $(VERSION)),true,false)
|
|
MAJOR_VERSION = $(word 1, $(subst ., ,$(VERSION)))
|
|
MINOR_VERSION = $(word 2, $(subst ., ,$(VERSION)))
|
|
PATCH_VERSION = $(word 3, $(subst ., ,$(word 1,$(subst -, , $(VERSION)))))
|
|
NEW_VERSION ?= $(MAJOR_VERSION).$(MINOR_VERSION).$(shell echo $$(( $(PATCH_VERSION) + 1)) )
|
|
|
|
fix = false
|
|
ifeq (true,$(fix))
|
|
FIX = --fix
|
|
endif
|
|
|
|
ACT ?= go run main.go
|
|
|
|
GOLANGCI_LINT_PACKAGE ?= github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.11.4
|
|
|
|
HAS_TOKEN = $(if $(test -e ~/.config/github/token),true,false)
|
|
ifeq (true,$(HAS_TOKEN))
|
|
export GITHUB_TOKEN := $(shell cat ~/.config/github/token)
|
|
endif
|
|
|
|
.PHONY: pr
|
|
pr: tidy format-all lint test
|
|
|
|
.PHONY: build
|
|
build:
|
|
go build -ldflags "-X main.version=$(VERSION)" -o dist/local/act main.go
|
|
|
|
.PHONY: format
|
|
format:
|
|
go run $(GOLANGCI_LINT_PACKAGE) fmt
|
|
|
|
.PHONY: format-check
|
|
format-check: format
|
|
@diff=$$(git diff --color=always); \
|
|
if [ -n "$$diff" ]; then \
|
|
echo "Please run 'make format' and commit the result:"; \
|
|
printf "%s" "$${diff}"; \
|
|
exit 1; \
|
|
fi
|
|
|
|
.PHONY: format-all
|
|
format-all: format
|
|
npx prettier --write .
|
|
|
|
.PHONY: test
|
|
test:
|
|
go test ./...
|
|
$(ACT)
|
|
|
|
.PHONY: lint-go
|
|
lint-go:
|
|
go run $(GOLANGCI_LINT_PACKAGE) run $(FIX)
|
|
|
|
.PHONY: lint-js
|
|
lint-js:
|
|
npx standard $(FIX)
|
|
|
|
.PHONY: lint-md
|
|
lint-md:
|
|
npx markdownlint . $(FIX)
|
|
|
|
.PHONY: lint-rest
|
|
lint-rest:
|
|
docker run --rm -it \
|
|
-v $(PWD):/tmp/lint \
|
|
-e GITHUB_STATUS_REPORTER=false \
|
|
-e GITHUB_COMMENT_REPORTER=false \
|
|
megalinter/megalinter-go:v5
|
|
|
|
.PHONY: lint
|
|
lint: lint-go lint-rest
|
|
|
|
.PHONY: lint-fix
|
|
lint-fix: lint-md lint-go
|
|
|
|
.PHONY: fix
|
|
fix:
|
|
make lint-fix fix=true
|
|
|
|
.PHONY: tidy
|
|
tidy:
|
|
go mod tidy
|
|
|
|
.PHONY: install
|
|
install: build
|
|
@cp dist/local/act $(PREFIX)/bin/act
|
|
@chmod 755 $(PREFIX)/bin/act
|
|
@act --version
|
|
|
|
.PHONY: installer
|
|
installer:
|
|
@GO111MODULE=off go get github.com/goreleaser/godownloader
|
|
godownloader -r nektos/act -o install.sh
|
|
|
|
.PHONY: promote
|
|
promote:
|
|
@git fetch --tags
|
|
@echo "VERSION:$(VERSION) IS_SNAPSHOT:$(IS_SNAPSHOT) NEW_VERSION:$(NEW_VERSION)"
|
|
ifeq (false,$(IS_SNAPSHOT))
|
|
@echo "Unable to promote a non-snapshot"
|
|
@exit 1
|
|
endif
|
|
ifneq ($(shell git status -s),)
|
|
@echo "Unable to promote a dirty workspace"
|
|
@exit 1
|
|
endif
|
|
echo -n $(NEW_VERSION) > VERSION
|
|
git add VERSION
|
|
git commit -m "chore: bump VERSION to $(NEW_VERSION)"
|
|
git tag -a -m "releasing v$(NEW_VERSION)" v$(NEW_VERSION)
|
|
git push origin master
|
|
git push origin v$(NEW_VERSION)
|
|
|
|
.PHONY: snapshot
|
|
snapshot:
|
|
goreleaser build \
|
|
--clean \
|
|
--single-target \
|
|
--snapshot
|
|
|
|
.PHONY: clean all
|