mirror of
https://gitea.com/gitea/act_runner.git
synced 2026-04-25 13:20:32 +08:00
Use `golangci-lint fmt` to format code, upgrading `.golangci.yml` to v2 and mirroring the linter configuration used by https://github.com/go-gitea/gitea. `gci` now handles import ordering into standard, project-local, blank, and default groups. Mirrors https://github.com/go-gitea/gitea/pull/37194. Changes: - Upgrade `.golangci.yml` to v2 format with the same linter set as gitea (minus `prealloc`, `unparam`, `testifylint`, `nilnil` which produced too many pre-existing issues) - Add path-based exclusions (`bodyclose`, `gosec` in tests; `gosec:G115`/`G117` globally) - Run lint via `make lint-go` in CI instead of `golangci/golangci-lint-action`, matching the pattern used by other Gitea repos - Apply safe auto-fixes (`modernize`, `perfsprint`, `usetesting`, etc.) - Add explanations to existing `//nolint` directives - Remove dead code (unused `newRemoteReusableWorkflow` and `networkName`), duplicate imports, and shadowed `max` builtins - Replace deprecated `docker/distribution/reference` with `distribution/reference` - Fix `Deprecated:` comment casing and simplify nil/len checks --- This PR was written with the help of Claude Opus 4.7 Reviewed-on: https://gitea.com/gitea/act/pulls/163 Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: silverwind <me@silverwind.io> Co-committed-by: silverwind <me@silverwind.io>
76 lines
1.5 KiB
Go
76 lines
1.5 KiB
Go
package runner
|
|
|
|
import (
|
|
"archive/tar"
|
|
"bytes"
|
|
"context"
|
|
"io"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestActionCache(t *testing.T) {
|
|
a := assert.New(t)
|
|
cache := &GoGitActionCache{
|
|
Path: t.TempDir(),
|
|
}
|
|
ctx := context.Background()
|
|
cacheDir := "nektos/act-test-actions"
|
|
repo := "https://github.com/nektos/act-test-actions"
|
|
refs := []struct {
|
|
Name string
|
|
CacheDir string
|
|
Repo string
|
|
Ref string
|
|
}{
|
|
{
|
|
Name: "Fetch Branch Name",
|
|
CacheDir: cacheDir,
|
|
Repo: repo,
|
|
Ref: "main",
|
|
},
|
|
{
|
|
Name: "Fetch Branch Name Absolutely",
|
|
CacheDir: cacheDir,
|
|
Repo: repo,
|
|
Ref: "refs/heads/main",
|
|
},
|
|
{
|
|
Name: "Fetch HEAD",
|
|
CacheDir: cacheDir,
|
|
Repo: repo,
|
|
Ref: "HEAD",
|
|
},
|
|
{
|
|
Name: "Fetch Sha",
|
|
CacheDir: cacheDir,
|
|
Repo: repo,
|
|
Ref: "de984ca37e4df4cb9fd9256435a3b82c4a2662b1",
|
|
},
|
|
}
|
|
for _, c := range refs {
|
|
t.Run(c.Name, func(t *testing.T) {
|
|
sha, err := cache.Fetch(ctx, c.CacheDir, c.Repo, c.Ref, "")
|
|
if !a.NoError(err) || !a.NotEmpty(sha) {
|
|
return
|
|
}
|
|
atar, err := cache.GetTarArchive(ctx, c.CacheDir, sha, "js")
|
|
if !a.NoError(err) || !a.NotEmpty(atar) {
|
|
return
|
|
}
|
|
mytar := tar.NewReader(atar)
|
|
th, err := mytar.Next()
|
|
if !a.NoError(err) || !a.NotEqual(0, th.Size) {
|
|
return
|
|
}
|
|
buf := &bytes.Buffer{}
|
|
// G110: Potential DoS vulnerability via decompression bomb (gosec)
|
|
_, err = io.Copy(buf, mytar)
|
|
a.NoError(err)
|
|
str := buf.String()
|
|
a.NotEmpty(str)
|
|
})
|
|
}
|
|
}
|