modules/fm-orchestrator
1
0
Fork 0
mirror of https://pagure.io/fm-orchestrator.git synced 2026-02-14 02:25:02 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Accept floats when filtering by stream_version_lte on the API

Browse Source
This commit is contained in:
mprahl
2019-06-17 13:37:15 -04:00
parent 392a456dab
commit 1a17d655ee
2 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
module_build_service/utils/views.py
View File

@@ -320,10 +320,10 @@ def filter_module_builds(flask_request):
if stream_version_lte is not None:
invalid_error = (
"An invalid value of stream_version_lte was provided. It must be an "
"integer greater than or equal to 10000."
"integer or float greater than or equal to 10000."
)
try:
stream_version_lte = int(stream_version_lte)
stream_version_lte = float(stream_version_lte)
except (TypeError, ValueError):
raise ValidationError(invalid_error)

9
tests/test_views/test_views.py
View File

@@ -683,7 +683,10 @@ class TestViews:
"An invalid Zulu ISO 8601 timestamp was " 'provided for the "modified_after" parameter'
assert data["status"] == 400
@pytest.mark.parametrize("stream_version_lte", ("280000", "290000", "293000", "invalid"))
@pytest.mark.parametrize(
"stream_version_lte",
("280000", "280000.0", "290000", "293000", "invalid"),
)
def test_query_builds_filter_stream_version_lte(self, stream_version_lte):
init_data(data_size=1, multiple_stream_versions=True)
url = (
@@ -698,11 +701,11 @@ class TestViews:
"error": "Bad Request",
"message": (
"An invalid value of stream_version_lte was provided. It must be an "
"integer greater than or equal to 10000."
"integer or float greater than or equal to 10000."
),
"status": 400,
}
elif stream_version_lte == "280000":
elif stream_version_lte in ("280000", "280000.0"):
assert total == 2
elif stream_version_lte == "290000":
assert total == 1