Mark these functions as "private".

This commit is contained in:
Ralph Bean
2017-02-10 15:53:36 -05:00
parent 88aca055ce
commit 2887e71b29
2 changed files with 6 additions and 6 deletions

View File

@@ -51,7 +51,7 @@ def _load_secrets():
'r').read())
client_secrets = list(secrets.values())[0]
def get_token_info(token):
def _get_token_info(token):
"""
Asks the token_introspection_uri for the validity of a token.
"""
@@ -71,7 +71,7 @@ def get_token_info(token):
return _json_loads(content)
def get_user_info(token):
def _get_user_info(token):
"""
Asks the userinfo_uri for more information on a user.
"""
@@ -100,7 +100,7 @@ def get_user(request):
token = request.cookies["oidc_token"]
try:
data = get_token_info(token)
data = _get_token_info(token)
except Exception as e:
error = "Cannot verify OIDC token: %s" % str(e)
log.exception(error)
@@ -110,7 +110,7 @@ def get_user(request):
raise Unauthorized("OIDC token invalid or expired.")
try:
extended_data = get_user_info(token)
extended_data = _get_user_info(token)
except Exception as e:
error = "Cannot verify determine user groups: %s" % str(e)
log.exception(error)

View File

@@ -39,7 +39,7 @@ class TestAuthModule(unittest.TestCase):
module_build_service.auth.get_user(request)
@raises(module_build_service.errors.Unauthorized)
@patch('module_build_service.auth.get_token_info')
@patch('module_build_service.auth._get_token_info')
def test_get_user_failure(self, get_token_info):
def mocked_get_token_info(token):
return {"active": False}
@@ -50,7 +50,7 @@ class TestAuthModule(unittest.TestCase):
module_build_service.auth.get_user(request)
@raises(module_build_service.errors.Unauthorized)
@patch('module_build_service.auth.get_token_info')
@patch('module_build_service.auth._get_token_info')
def test_get_user_good(self, get_token_info):
# https://www.youtube.com/watch?v=G-LtddOgUCE
name = "Joey Jo Jo Junior Shabadoo"