mirror of
https://pagure.io/fm-orchestrator.git
synced 2026-04-05 11:48:33 +08:00
Be careful with attribute access here.
I hit a traceback where msg was NoneType and therefore didn't have a `msg_id` attribute, I therefore wasn't able to see the real exception that got me there in the first place.
This commit is contained in:
@@ -126,8 +126,7 @@ class MBSConsumer(fedmsg.consumers.FedmsgConsumer):
|
||||
with models.make_session(conf) as session:
|
||||
self.process_message(session, msg)
|
||||
except Exception:
|
||||
log.exception('Failed while handling {0!r}'.format(msg.msg_id))
|
||||
log.info(msg)
|
||||
log.exception('Failed while handling {0!r}'.format(msg))
|
||||
|
||||
if self.stop_condition and self.stop_condition(message):
|
||||
self.shutdown()
|
||||
|
||||
Reference in New Issue
Block a user