modules/fm-orchestrator
1
0
Fork 0
mirror of https://pagure.io/fm-orchestrator.git synced 2026-04-02 02:11:19 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

Use a random build_id instead of an incrementing one in FakeModuleBuilder

Browse Source 
I ran into issues on CentOS CI where fake Koji build messages were getting
one ID but the task_id for the component in the database was getting
another. Making the build_id random and not tied to the class seems to
resolve that issue.
This commit is contained in:
mprahl
2018-02-05 22:05:52 -05:00
parent b7998d4402
commit ea650047a1
1 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
tests/test_build/test_build.py
View File

@@ -93,9 +93,6 @@ class FakeModuleBuilder(GenericBuilder):
"""
backend = "test"
# Global build_id/task_id we increment when new build is executed.
_build_id = 0
BUILD_STATE = "COMPLETE"
# Simulates a situation when a component is already built in Koji
INSTANT_COMPLETE = False
@@ -229,18 +226,17 @@ class FakeModuleBuilder(GenericBuilder):
def build(self, artifact_name, source):
print("Starting building artifact %s: %s" % (artifact_name, source))
FakeModuleBuilder._build_id += 1
build_id = randint(1000, 9999999)
if FakeModuleBuilder.on_build_cb:
FakeModuleBuilder.on_build_cb(self, artifact_name, source)
if FakeModuleBuilder.BUILD_STATE != "BUILDING":
self._send_build_change(
koji.BUILD_STATES[FakeModuleBuilder.BUILD_STATE], artifact_name,
FakeModuleBuilder._build_id)
koji.BUILD_STATES[FakeModuleBuilder.BUILD_STATE], artifact_name, build_id)
reason = "Submitted %s to Koji" % (artifact_name)
return FakeModuleBuilder._build_id, koji.BUILD_STATES['BUILDING'], reason, None
return build_id, koji.BUILD_STATES['BUILDING'], reason, None
@staticmethod
def get_disttag_srpm(disttag, module_build):