pytest thinks `TestModuleBuilder` looks like a test
class name, so it complains about the presence of
an `__init__` method.
Changing the name of the helper class avoids the
warning.
This was introduced months ago, but we never hit it. I just saw it in
the error logs.
It looks like the call to `session.untaggedBuilds` expects a `name`
argument, but `session.listTagged` does *not*.
We used to do x509 authn a long time ago. We have since stopped doing
that, but we kept all of thise confusing SSL/TLS support stuff.
This removes all that, and fixes#685.
Today, we ignore koji messages with a None `task_id` in two ways. First
with a conditional, and then with a second check in the message
`__init__` method. This is a belt-and-suspenders approach.
For other reasons in the UMB messaging plugin, we'd like to put this
check in just one place and use a special exception in the initializer
instead of in a conditional beforehand.
Fixes:
```
File "/usr/lib/python2.7/site-packages/module_build_service/pdc.py", line 193, in get_module
retval = session['unreleasedvariants/'](page_size=1, **query)
File "<string>", line 1, in <lambda>
File "/usr/lib/python2.7/site-packages/beanbag/namespace.py", line 136, in fn
*args, **kwargs)
File "/usr/lib/python2.7/site-packages/beanbag/url_v1.py", line 102, in call
return self.make_request(path, verb, kwargs, body)
File "/usr/lib/python2.7/site-packages/beanbag/url_v1.py", line 155, in make_request
"Bad response code: %d" % (r.status_code,))
beanbag.bbexcept.BeanBagException: Bad response code: 404
```
Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
The message format broke in 3cb41aa5dc
The resulted in tracebacks in pdc-updater when it tried to learn things
about a module that was just submitted. It relied on certain fields
(`stream`) being in the message body. This change restores those fields
to get things working again.
We need to check for the error here *before* we make a second request
for the "last page". If we don't, we can end up submitting a query
asking for "page 0" which fails without a helpful message.
