Take advantage of the information contained in signature/parameter
objects to represent positional and keyword arguments properly. Fall
back to using the funcsigs module on Python 2.
koji.read_config() filters out configuration options it doesn't know
about silently. Currently this is about the keytab, principal, ccache
options. The latter may be needed e.g. in Docker containers which
currently(?) can't use Linux kernel keyrings and need the credential
cache to be a normal file.
Before this, we were consulting pkgdb to see if the given user was the
maintainer of any packages.
That mostly works... but technically, we want to consult FAS to see if
the user is in the packager group.
We found this when @mprahl was unable to submit builds to rida. I added
him to the packager group, but nothing changed! (As written, he had to
actually own a package).
This change fixes all that so that we query FAS instead of pkgdb.
Tests are added.
Using vars() this way breaks passing the koji configuration options to
koji.ClientSession(), it passes an empty dict instead. Any options in
koji.conf which are needed for authenticating are ineffectual (e.g.
`krbservice`).
As of now we don't do anything useful in between done (read: module
build is done) and ready (read: module is ready for consumption).
Thus I recommend direct transition and return to it back
when we have automatic dependency rebuild done.
Signed-off-by: Lubos Kocman <lkocman@redhat.com>
Signed-off-by: Nils Philippsen <nils@redhat.com>
- function returns task_id if associated build exists
- fix typo in docstring
- Nils is disappointed by Guido
Signed-off-by: Lubos Kocman <lkocman@redhat.com>
Signed-off-by: Nils Philippsen <nils@redhat.com>
- Allows to call build() and connect() multiple times. This needs to be
followed by allowing to resubmit module build tasks in REST.
- rename buildroot_add_repo() to buildroot_add_repos() (input data is artifacts)
Signed-off-by: Lubos Kocman <lkocman@redhat.com>
Signed-off-by: Nils Philippsen <nils@redhat.com>
- merge buildroot_prep and buildroot_resume under buildroot_connect
https://pagure.io/fm-orchestrator/issue/34 (idempotent movement)
- rename add_dependency to add_repo
- provide workflow comparison koji vs copr as a docstring
- update docstrings for GenericBuilder
Signed-off-by: Lubos Kocman <lkocman@redhat.com>
Signed-off-by: Nils Philippsen <nils@redhat.com>
