Use Popen's returncode instead of getstatusoutput

because the getstatusoutput is python3 only
This commit is contained in:
Jakub Kadlčík
2016-08-17 13:22:45 +02:00
committed by Nils Philippsen
parent 42e2686a99
commit 3ba33f4e53

View File

@@ -137,9 +137,10 @@ class SCM(object):
:raises: RuntimeError
"""
if self.scheme == "git":
(status , output) = sp.getstatusoutput("git ls-remote %s"
% self.repository)
if status != 0:
cmd = ["git", "ls-remote", self.repository]
proc = sp.Popen(cmd, stdout=sp.PIPE, stderr=sp.PIPE)
output, stderr = proc.communicate()
if proc.returncode != 0:
raise RuntimeError("Cannot get git hash of master HEAD in %s"
% self.repository)
for line in output.split(os.linesep):