Update Windows CI builds to multi-agent matrix

This PR updates Windows CI builds to use a multi-agent matrix when
building. Windows 2022 & 2019 have been DISABLED *temporarily* until
we can find a way to automagically detect the location of Visual
Studio build tools.

The only build agent available is Windows 2016, as it works with the
current setup. There is a publishing step, which only runs on the
Windows 2016 agent for now. This solves the issue of multiple
installer artifacts being built when the other agents are
re-enabled.

Per-commit generated binaries remain generated by all (not right now)
Windows build agenst.

Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>

README.md

@@ -86,7 +86,7 @@ specific packages.
 
 **Q: Does drag and drop work on linux?**
 
-> A: No *(see [#855](https://github.com/debauchee/barrier/issues/855) if you'd like to change that)*
+> A: No *(see [#855](https://github.com/debauchee/barrier/issues/544) if you'd like to change that)*
 
 
 **Q: What OSes are supported?**

azure-pipelines.yml

@@ -9,14 +9,28 @@ trigger:
 jobs:
 - job: WinBuild
   displayName: Windows Build
-  pool:
-    vmImage: 'vs2017-win2016'
   strategy:
     matrix:
-      Debug:
-        CI_ENV_BUILD_TYPE: Debug
-      Release with Release Installer:
-        CI_ENV_BUILD_TYPE: Release
+#        windows-2022-Debug:
+#            imageName: "windows-2022"
+#            CI_ENV_BUILD_TYPE: Debug
+#        windows-2022-Release:
+#            imageName: "windows-2022"
+#            CI_ENV_BUILD_TYPE: Release
+#        windows-2019-Debug:
+#            imageName: "windows-2019"
+#            CI_ENV_BUILD_TYPE: Debug
+#        windows-2019-Release:
+#            imageName: "windows-2019"
+#            CI_ENV_BUILD_TYPE: Release
+        windows-2016-Debug:
+            CI_ENV_BUILD_TYPE: Debug
+            imageName: "vs2017-win2016"
+        windows-2016-Release:
+            CI_ENV_BUILD_TYPE: Release
+            imageName: "vs2017-win2016"
+  pool:
+    vmImage: $(imageName)
   steps:
     # Gather Dependencies
     - task: PowerShell@2

doc/newsfragments/linux-drag-drop-faq.doc

@@ -1 +0,0 @@
-Fixed FAQ link to Linux drag and drop issue.

doc/newsfragments/restore-dpiawareness.bugfix

@@ -1 +0,0 @@
-Fixed a regression in 2.4.0 that caused Barrier to not support scaling other than 100% (https://github.com/debauchee/barrier/issues/1462).

src/cmd/barrierc/CMakeLists.txt

@@ -21,9 +21,7 @@ set(sources
 if (WIN32)
     file(GLOB arch_headers "MSWindows*.h")
     file(GLOB arch_sources "MSWindows*.cpp")
-    list(APPEND sources
-        barrierc.rc
-        barrierc.exe.manifest)
+    list(APPEND sources barrierc.rc)
 elseif (APPLE)
     file(GLOB arch_headers "OSX*.h")
     file(GLOB arch_sources "OSX*.cpp")

src/cmd/barrierc/barrierc.exe.manifest

@@ -1,16 +0,0 @@
-<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
-<assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0">
-    <trustInfo xmlns="urn:schemas-microsoft-com:asm.v3">
-        <security>
-            <requestedPrivileges>
-                <requestedExecutionLevel level="asInvoker" uiAccess="false"></requestedExecutionLevel>
-            </requestedPrivileges>
-        </security>
-    </trustInfo>
-    <application xmlns="urn:schemas-microsoft-com:asm.v3">
-        <windowsSettings>
-            <dpiAware xmlns="http://schemas.microsoft.com/SMI/2005/WindowsSettings">true</dpiAware>
-            <dpiAwareness xmlns="http://schemas.microsoft.com/SMI/2016/WindowsSettings">PerMonitor</dpiAwareness>
-        </windowsSettings>
-    </application>
-</assembly>

src/cmd/barriers/CMakeLists.txt

@@ -21,9 +21,7 @@ set(sources
 if (WIN32)
     file(GLOB arch_headers "MSWindows*.h")
     file(GLOB arch_sources "MSWindows*.cpp")
-    list(APPEND sources
-        barriers.rc
-        barriers.exe.manifest)
+    list(APPEND sources barriers.rc)
 elseif (APPLE)
     file(GLOB arch_headers "OSX*.h")
     file(GLOB arch_sources "OSX*.cpp")

src/cmd/barriers/barriers.exe.manifest

@@ -1,16 +0,0 @@
-<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
-<assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0">
-    <trustInfo xmlns="urn:schemas-microsoft-com:asm.v3">
-        <security>
-            <requestedPrivileges>
-                <requestedExecutionLevel level="asInvoker" uiAccess="false"></requestedExecutionLevel>
-            </requestedPrivileges>
-        </security>
-    </trustInfo>
-    <application xmlns="urn:schemas-microsoft-com:asm.v3">
-        <windowsSettings>
-            <dpiAware xmlns="http://schemas.microsoft.com/SMI/2005/WindowsSettings">true</dpiAware>
-            <dpiAwareness xmlns="http://schemas.microsoft.com/SMI/2016/WindowsSettings">PerMonitor</dpiAwareness>
-        </windowsSettings>
-    </application>
-</assembly>

src/gui/res/mac/Info.plist

@@ -1,4 +1,3 @@
-<?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE plist PUBLIC "-//Apple Computer//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
 <plist version="1.0">
   <dict>

src/lib/barrier/FileChunk.cpp

@@ -98,7 +98,7 @@ FileChunk::assemble(barrier::IStream* stream, String& dataReceived, size_t& expe
     case kDataChunk:
         dataReceived.append(content);
         if (CLOG->getFilter() >= kDEBUG2) {
-                LOG((CLOG_DEBUG2 "recv file chunk size=%i", content.size()));
+                LOG((CLOG_DEBUG2 "recv file chunck size=%i", content.size()));
                 double interval = stopwatch.getTime();
                 receivedDataSize += content.size();
                 LOG((CLOG_DEBUG2 "recv file interval=%f s", interval));

src/lib/net/SecureUtils.cpp

@@ -190,7 +190,7 @@ void generate_pem_self_signed_cert(const std::string& path)
 
     X509_sign(cert, private_key, EVP_sha256());
 
-    auto fp = fopen_utf8_path(path.c_str(), "w");
+    auto fp = fopen_utf8_path(path.c_str(), "r");
     if (!fp) {
         throw std::runtime_error("Could not open certificate output path");
     }

src/lib/platform/XWindowsScreen.cpp

@@ -324,7 +324,7 @@ XWindowsScreen::leave()
     m_impl->XGetInputFocus(m_display, &m_lastFocus, &m_lastFocusRevert);
 
 	// take focus
-	if (!m_preserveFocus) {
+	if (m_isPrimary || !m_preserveFocus) {
         m_impl->XSetInputFocus(m_display, m_window, RevertToPointerRoot, CurrentTime);
 	}